Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4621] Implement TransformerEngine for EventMesh Transformer #4622

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Dec 7, 2023

Fixes #4621 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (6508df8) 16.80% compared to head (40f1098) 16.90%.
Report is 6 commits behind head on master.

Files Patch % Lines
...ache/eventmesh/runtime/boot/TransformerEngine.java 0.00% 56 Missing ⚠️
.../core/protocol/http/push/AsyncHTTPPushRequest.java 0.00% 12 Missing ⚠️
.../apache/eventmesh/transformer/TransformerType.java 41.17% 10 Missing ⚠️
...otocol/http/processor/SendAsyncEventProcessor.java 0.00% 6 Missing ⚠️
...apache/eventmesh/transformer/TransformerParam.java 77.77% 4 Missing ⚠️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.00% 3 Missing ⚠️
...ache/eventmesh/transformer/TransformerBuilder.java 60.00% 1 Missing and 1 partial ⚠️
...ava/org/apache/eventmesh/transformer/Template.java 50.00% 0 Missing and 1 partial ⚠️
...ava/org/apache/eventmesh/transformer/Variable.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4622      +/-   ##
============================================
+ Coverage     16.80%   16.90%   +0.10%     
- Complexity     1678     1703      +25     
============================================
  Files           782      790       +8     
  Lines         29317    29522     +205     
  Branches       2532     2550      +18     
============================================
+ Hits           4926     4991      +65     
- Misses        23932    24065     +133     
- Partials        459      466       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qqeasonchen qqeasonchen merged commit 8c59c7f into apache:master Dec 7, 2023
13 checks passed
@xwm1992 xwm1992 added this to the 1.10 milestone Dec 12, 2023
String value = transformerDataEntry.getValue();
updateTransformerMap(key, value);
}
metaServiceListener = this::updateTransformerMap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this step be placed before for( ), otherwise, is it possible for metaServiceListener to be null when addTransformerListener() in updateTransformerMap()?

这一步是不是应该放到for( )前面,否则的话,updateTransformerMap()addTransformerListener()时,metaServiceListener是不是为null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement TransformerEngine for EventMesh Transformer
4 participants