Skip to content

Commit dbabca7

Browse files
committed
Remove the unique callee/caller close() of onCompleted()
1 parent 4d86948 commit dbabca7

File tree

1 file changed

+4
-12
lines changed
  • eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer

1 file changed

+4
-12
lines changed

eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/SubStreamHandler.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ public class SubStreamHandler<T> extends Thread implements Serializable {
4040

4141
private final transient CountDownLatch latch = new CountDownLatch(1);
4242

43-
private volatile boolean isClosed = false;
44-
4543
private final transient ConsumerServiceStub consumerAsyncClient;
4644

4745
private final transient EventMeshGrpcClientConfig clientConfig;
@@ -104,7 +102,6 @@ public void onError(final Throwable t) {
104102
@Override
105103
public void onCompleted() {
106104
log.info("Finished receiving messages from server.");
107-
close();
108105
}
109106
};
110107
}
@@ -132,16 +129,11 @@ public void run() {
132129
}
133130

134131
public void close() {
135-
synchronized (sender) {
136-
if (isClosed) {
137-
return;
138-
}
139-
if (this.sender != null) {
140-
senderOnComplete();
141-
}
142-
latch.countDown();
143-
isClosed = true;
132+
if (this.sender != null) {
133+
senderOnComplete();
144134
}
135+
136+
latch.countDown();
145137
log.info("SubStreamHandler closed.");
146138
}
147139

0 commit comments

Comments
 (0)