Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4575] Upgrade to use fastjson 1.2.58 #4579

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

biyuhao
Copy link
Member

@biyuhao biyuhao commented Jul 16, 2019

What is the purpose of the change

fix #4575

Brief changelog

Upgrade to use fastjson 1.2.58

Verifying this change

UT pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4579 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #4579     +/-   ##
===========================================
- Coverage     63.29%   63.19%   -0.1%     
- Complexity      448      450      +2     
===========================================
  Files           770      770             
  Lines         33008    33008             
  Branches       5216     5202     -14     
===========================================
- Hits          20891    20861     -30     
- Misses         9714     9737     +23     
- Partials       2403     2410      +7
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 44.79% <0%> (-3.13%) 0% <0%> (ø)
...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java 68.57% <0%> (-2.86%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-2.69%) 0% <0%> (ø)
.../dubbo/metadata/identifier/MetadataIdentifier.java 58.13% <0%> (-2.33%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/exchange/Request.java 84.44% <0%> (-2.23%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/IOUtils.java 86.95% <0%> (-2.18%) 0% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e44db...3c093fc. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30 beiwei30 merged commit 214ec1f into apache:master Jul 16, 2019
@biyuhao biyuhao deleted the issue-4575 branch July 17, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to upgrade to use fastjson 1.2.58
3 participants