Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step3 - start to use RpcConstants #4038

Merged
merged 6 commits into from
May 13, 2019

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

issue #3137:
step3 - start to use RpcConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
#	dubbo-registry/dubbo-registry-default/src/main/java/org/apache/dubbo/registry/dubbo/DubboRegistryFactory.java
#	dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java
#	dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java
#	dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolListenerWrapper.java
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beiwei30
Copy link
Member

but CI fails due to this:

[ERROR] src/main/java/org/apache/dubbo/rpc/RpcContext.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants.
[ERROR] src/main/java/org/apache/dubbo/rpc/protocol/ProtocolListenerWrapper.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants.
[ERROR] src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants.

@codecov-io
Copy link

Codecov Report

Merging #4038 into master will decrease coverage by 0.37%.
The diff coverage is 69.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4038      +/-   ##
============================================
- Coverage     63.46%   63.08%   -0.38%     
  Complexity      565      565              
============================================
  Files           753      753              
  Lines         32416    32411       -5     
  Branches       5143     5143              
============================================
- Hits          20572    20448     -124     
- Misses         9484     9615     +131     
+ Partials       2360     2348      -12
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/cluster/router/tag/TagRouter.java 35.86% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/monitor/dubbo/DubboMonitorFactory.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...va/org/apache/dubbo/rpc/filter/TpsLimitFilter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/apache/dubbo/common/Constants.java 75% <ø> (-8.34%) 0 <0> (ø)
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <ø> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/mina/MinaServer.java 63.33% <ø> (ø) 6 <0> (ø) ⬇️
...src/main/java/org/apache/dubbo/rpc/RpcContext.java 70% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/rpc/filter/EchoFilter.java 75% <0%> (ø) 0 <0> (ø) ⬇️
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 63.95% <0%> (ø) 0 <0> (ø) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805f7c7...749976f. Read the comment docs.

@beiwei30 beiwei30 merged commit e690864 into apache:master May 13, 2019
@CrazyHZM CrazyHZM deleted the constantStep3rpc branch May 14, 2019 09:27
lonre added a commit to lonre/dubbo that referenced this pull request Jul 13, 2019
lonre added a commit to lonre/dubbo that referenced this pull request Jul 13, 2019
beiwei30 pushed a commit that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants