-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUBBO-3137]: step3 - start to use RpcConstants #4038
Conversation
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java # dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java # dubbo-registry/dubbo-registry-default/src/main/java/org/apache/dubbo/registry/dubbo/DubboRegistryFactory.java # dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/RegistryDirectoryTest.java # dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java # dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/ProtocolListenerWrapper.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
but CI fails due to this: [ERROR] src/main/java/org/apache/dubbo/rpc/RpcContext.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants.
[ERROR] src/main/java/org/apache/dubbo/rpc/protocol/ProtocolListenerWrapper.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants.
[ERROR] src/main/java/org/apache/dubbo/rpc/protocol/ProtocolFilterWrapper.java:[19,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.Constants. |
Codecov Report
@@ Coverage Diff @@
## master #4038 +/- ##
============================================
- Coverage 63.46% 63.08% -0.38%
Complexity 565 565
============================================
Files 753 753
Lines 32416 32411 -5
Branches 5143 5143
============================================
- Hits 20572 20448 -124
- Misses 9484 9615 +131
+ Partials 2360 2348 -12
Continue to review full report at Codecov.
|
which introduced by apache#4038
What is the purpose of the change
issue #3137:
step3 - start to use RpcConstants
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.