Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2424] Fix switch-case fall through in ChannelEventRunnable #2426

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

biyuhao
Copy link
Member

@biyuhao biyuhao commented Sep 2, 2018

What is the purpose of the change

Fix #2424

Brief changelog

Add missing break statement in ChannelEventRunnable#run

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2426 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2426     +/-   ##
===========================================
- Coverage     55.14%   55.05%   -0.1%     
+ Complexity     5274     5270      -4     
===========================================
  Files           573      573             
  Lines         25459    25460      +1     
  Branches       4537     4537             
===========================================
- Hits          14039    14016     -23     
- Misses         9327     9349     +22     
- Partials       2093     2095      +2
Impacted Files Coverage Δ Complexity Δ
...ing/transport/dispatcher/ChannelEventRunnable.java 79.16% <0%> (-1.69%) 9 <0> (ø)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-10.17%) 12% <0%> (-1%)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...ng/zookeeper/zkclient/ZkclientZookeeperClient.java 59.52% <0%> (-4.77%) 10% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-4.17%) 3% <0%> (ø)
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 59.79% <0%> (-4.13%) 14% <0%> (-2%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
...pache/dubbo/registry/support/AbstractRegistry.java 67.41% <0%> (-1.13%) 62% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae2f58...961cf56. Read the comment docs.

@@ -82,6 +82,7 @@ public void run() {
logger.warn("ChannelEventRunnable handle " + state + " operation error, channel is " + channel
+ ", message is " + message, e);
}
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@diecui1202
Copy link

It looks good to me.

@diecui1202 diecui1202 merged commit 51f0677 into apache:master Sep 11, 2018
@biyuhao biyuhao deleted the issue-2424 branch September 11, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch-case fall through in ChannelEventRunnable
4 participants