Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-#1322] refactor dubbo deployment process #1389

Merged
merged 17 commits into from
Mar 6, 2018
Merged

[Dubbo-#1322] refactor dubbo deployment process #1389

merged 17 commits into from
Mar 6, 2018

Conversation

chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Feb 23, 2018

What is the purpose of the change

Resolve #1322. We can run maven deploy in root directory and deploy all sub modules of dubbo project to central repository:

  1. dubbo.jar. all in one jar, same as before.
  2. dubbo-xxx.jar. a packaged jar for every sub module.

More details please check discussion in #1322.

Brief changelog

  1. extract serialization module from dubbo-common.
  2. change module name dubbo-rpc-default to dubbo-rpc-dubbo.
  3. change 'skip_maven_deploy' to false, so all modules can be deployed to central repository.
  4. upgrade hessian-lite version to 3.2.2.

Verifying this change

  1. run mvn deploy and see if dubbo project can be deployed to repository as expected.
  2. check dubbo.jar and every separated jar works fine in a simple demo.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@chickenlj chickenlj requested a review from weipeng2k March 6, 2018 12:00
# Conflicts:
#	dubbo-rpc/dubbo-rpc-dubbo/src/main/java/com/alibaba/dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
@chickenlj chickenlj merged commit 4a5c5e2 into apache:master Mar 6, 2018
@chickenlj chickenlj deleted the serialization_package branch March 6, 2018 12:04
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hope to split the sub-module deployed to maven alone.
1 participant