Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnet cannot call the correct overload method #3177

Closed
2 tasks
gudegg opened this issue Jan 9, 2019 · 7 comments · Fixed by #3210
Closed
2 tasks

telnet cannot call the correct overload method #3177

gudegg opened this issue Jan 9, 2019 · 7 comments · Fixed by #3210

Comments

@gudegg
Copy link
Contributor

gudegg commented Jan 9, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: master branch
  • Operating System version: Mac os
  • Java version: 1.8

Steps to reproduce this issue

org.apache.dubbo.rpc.protocol.dubbo.support.DemoService add method

 String getPerson(Yee yee);

org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl

    @Override
    public String getPerson(Yee yee) {
        return yee.getAddress();
    }
public class Yee implements Serializable {
    private String address;
}

public class Man implements Serializable {
    private static final long serialVersionUID = 1L;
    private String name;
    private int age;
}

org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl add UT

   @Test
    public void testInvokeMultiJsonParamMethod2() throws RemotingException {
        mockChannel = mock(Channel.class);
        given(mockChannel.getAttribute("telnet.service")).willReturn(null);
        given(mockChannel.getLocalAddress()).willReturn(NetUtils.toAddress("127.0.0.1:5555"));
        given(mockChannel.getRemoteAddress()).willReturn(NetUtils.toAddress("127.0.0.1:20886"));

        ProviderModel providerModel = new ProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", new DemoServiceImpl(), DemoService.class);
        ApplicationModel.initProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", providerModel);
        String param = "{\"address\":\"Dubbo\"}";
        String result = invoke.telnet(mockChannel, "getPerson(" + param + ")");
        assertTrue(result.contains("result: \"Dubbo"));
    }
  1. UT fail,Find the wrong overload method

Expected Result

Call getPerson(Yee yee)

Actual Result

Call getPerson(Man man)

Suggestion

If the overload method parameters are different in length, allowed to not pass class parameter, otherwise prompted user must pass the class parameter.

@beiwei30

@carryxyh
Copy link
Member

carryxyh commented Jan 9, 2019

这个issue是已知的,对于重载的支持不好。但是我忘记具体的issue是在哪里了。yiji提交过类似的issue。
@zonghaishang

@carryxyh
Copy link
Member

carryxyh commented Jan 9, 2019

找到了:
#2766

@gudegg
你可以看下,如果反应的是同一个问题,这个issue就先关掉吧。

@LiZhenNet
Copy link
Contributor

找到了:
#2766

@gudegg
你可以看下,如果反应的是同一个问题,这个issue就先关掉吧。

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

@CrazyHZM
Copy link
Member

CrazyHZM commented Jan 9, 2019

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

关于哪个pr

@carryxyh
Copy link
Member

carryxyh commented Jan 9, 2019

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

@LiZhenNet 好的。

@kexianjun
Copy link
Member

In this case, maybe specific parameter types is needed.

@tswstarplanet
Copy link
Contributor

I find that it is not an easy thing that support telnet perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants