Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the test coverage part-8 : dubbo-filter module #1687

Closed
lovepoem opened this issue Apr 26, 2018 · 5 comments
Closed

Enhance the test coverage part-8 : dubbo-filter module #1687

lovepoem opened this issue Apr 26, 2018 · 5 comments

Comments

@lovepoem
Copy link
Member

Add unit test to dubbo-filter module

@qinnnyul
Copy link
Contributor

qinnnyul commented Apr 27, 2018

@lovepoem hey, I would like to increase test coverages for dubbo-filter module.by the way, what is the target goal? 80%? or something else?

@lovepoem
Copy link
Member Author

ok,the base goal:60%,you can see in the page: https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide。

The more enough,the better

@htynkn
Copy link
Member

htynkn commented May 4, 2018

PR #1715 add unit test for dubbo-filter-cache. we still need unit test for dubbo-filter-validation

@qinnnyul
Copy link
Contributor

qinnnyul commented May 4, 2018

good eye! I will work on it, thanks

@lovepoem
Copy link
Member Author

close via #1715 and #1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants