Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Protoc plugin issue when generating java class files. #14567

Closed
3 of 4 tasks
chickenlj opened this issue Aug 22, 2024 · 0 comments · Fixed by #14723
Closed
3 of 4 tasks

[Bug] Protoc plugin issue when generating java class files. #14567

chickenlj opened this issue Aug 22, 2024 · 0 comments · Fixed by #14723
Assignees
@finefuture
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@chickenlj
Copy link
Contributor

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

3.3.0-beta

Steps to reproduce this issue

  1. plugin does not support generating all source codes into one single file. Currently must set option java_multiple_files = true;
  2. OuterClass is not generated by default but Service class relies on OuterClass, Currently must set option java_outer_classname = "MDSSyncServiceOuterClass";
  3. java_package does not work, classes still created in package not in java_package

image

image

image

What you expected to happen

  1. support single file mode by default or plugin can automatically use multiple files mode by force.
  2. Generate OuterClass by default or does not rely on OuterClass by default.
  3. java_package takes precedence of package if set.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@chickenlj chickenlj added type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage labels Aug 22, 2024
@chickenlj chickenlj changed the title [Bug] Protoc plugin [Bug] Protoc plugin issue when generating java class files. Aug 22, 2024
@finefuture finefuture self-assigned this Sep 25, 2024
@finefuture finefuture mentioned this issue Sep 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@finefuture finefuture

Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Dubbo Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support single file mode in dubbo-maven-plugin finefuture/dubbo
2 participants
@chickenlj @finefuture