-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] onError in Streaming Mode Does Not Support Returning Custom Exceptions #14415
Comments
@EarthChen PTAL |
Yeah, we haven't figured out how to support it yet |
@nikbobo I have great interest about this issue, could you assign it to me? |
I cannot assign to anyone, please contact project admin. |
@elysium-w Sure, but please write a brief proposal before coding. |
I think this requirement is unreasonable. Dubbo's stream is align to gRPC. In gRPC, if StreamObserver.onError is called within a stream, the error information is written back to the client via trailers, and the Throwable is not passed. then the stream is closed. A point we can optimization is provide extension that allow users to write additional error information back to the client. |
Pre-check
Search before asking
Apache Dubbo Component
Java SDK (apache/dubbo)
Descriptions
It is expected that the onError method of StreamObserver can pass through custom exceptions to the Consumer. Currently, the onError method in ServerCallToObserverAdapter is as follows:
This ultimately returns a StatusRpcException.
Related issues
No response
Are you willing to submit a pull request to fix on your own?
Code of Conduct
The text was updated successfully, but these errors were encountered: