Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Some of the sample guidance conforms to business usage #13859

Open
3 of 4 tasks
AlbumenJ opened this issue Mar 8, 2024 · 4 comments
Open
3 of 4 tasks

[Task] Some of the sample guidance conforms to business usage #13859

AlbumenJ opened this issue Mar 8, 2024 · 4 comments
Labels
component/samples Related with apache/dubbo-samples good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@AlbumenJ
Copy link
Member

AlbumenJ commented Mar 8, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java Samples (apache/dubbo-samples)

Descriptions

  1. EmbeddedZookeeper: Change to a regular zookeeper download, install startup commands
  2. Change samples to normal applications instead of directly loading XML within the Main function.

Related issues

#13847

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@AlbumenJ AlbumenJ added help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance component/samples Related with apache/dubbo-samples labels Mar 8, 2024
@AlbumenJ AlbumenJ changed the title [Feature] Some of the sample guidance conforms to business usage [Task] Some of the sample guidance conforms to business usage Mar 8, 2024
@AlbumenJ AlbumenJ added the good first issue Good for starters to contribute label Mar 8, 2024
@yuluo-yx
Copy link
Member

yuluo-yx commented Mar 24, 2024 •
edited
Loading

@AlbumenJ Is embedded-zookeeper being removed here in dubbo-examples?
and replace XML load to application.yaml configuration way?

https://github.com/apache/dubbo-samples/blob/c79de2129e20c07d6572c6a09519d48b6ec50781/3-extensions/protocol/dubbo-samples-webservice/dubbo-samples-webservice-provider/src/main/java/org/apache/dubbo/samples/webservice/provider/WebserviceProvider.java#L27

If so, please assign to me and I will try to complete this.

@CrazyHZM
Copy link
Member

CrazyHZM commented Mar 25, 2024 •
edited
Loading

@yuluo-yx
Yes, you can refer to other samples that have been completed.

@yuluo-yx
Copy link
Member

@yuluo-yx Yes, you can refer to other samples that have been completed.

Is there a pr link to an example? I didn't find a pr associated with the current issue.
Can I submit a pr as a separate commit for removing zookeeper and updating xml? There seems to be no correlation between the two

@yuluo-yx yuluo-yx mentioned this issue Mar 25, 2024
Open
@yuluo-yx
Copy link
Member

ptal @CrazyHZM

apache/dubbo-samples#1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/samples Related with apache/dubbo-samples good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Dubbo Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlbumenJ @CrazyHZM @yuluo-yx