Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: some improvements #98

Merged
merged 13 commits into from
Jun 19, 2019
Merged

Imp: some improvements #98

merged 13 commits into from
Jun 19, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

About some improvements.

Which issue(s) this PR fixes:

Fixes #79
Fixes #67
Fixes #59
Fixes #57

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

  • Improve the way of use in consumer.
  • Support none request , none response, nil request, nil response
  • Support lowercase function on the provider
  • Fix bug about Port Occupancy when multi-service

@gaoxinge
Copy link

LGTM

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #98 into master will increase coverage by 1.25%.
The diff coverage is 83.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   62.09%   63.34%   +1.25%     
==========================================
  Files          54       54              
  Lines        3580     3656      +76     
==========================================
+ Hits         2223     2316      +93     
+ Misses       1134     1114      -20     
- Partials      223      226       +3
Impacted Files Coverage Δ
protocol/dubbo/pool.go 62.01% <ø> (+6.87%) ⬆️
common/proxy/proxy_factory/default.go 100% <ø> (ø) ⬆️
common/logger/logger.go 87.23% <100%> (ø) ⬆️
config/reference_config.go 91.54% <100%> (ø) ⬆️
protocol/dubbo/server.go 71.42% <100%> (-0.41%) ⬇️
config/service_config.go 67.6% <100%> (ø) ⬆️
registry/directory/directory.go 78.3% <100%> (+0.2%) ⬆️
registry/zookeeper/registry.go 63.63% <100%> (ø) ⬆️
common/rpc_service.go 88.54% <100%> (-1.53%) ⬇️
protocol/dubbo/client.go 70.13% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f39b2...72f5336. Read the comment docs.

common/proxy/invoker.go Outdated Show resolved Hide resolved
protocol/dubbo/listener.go Outdated Show resolved Hide resolved
protocol/jsonrpc/jsonrpc_protocol.go Outdated Show resolved Hide resolved
config/config_loader.go Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 10d0f0f into apache:master Jun 19, 2019
@fangyincheng fangyincheng deleted the imp branch June 29, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants