-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Add grpc max message size config #824
Ftr: Add grpc max message size config #824
Conversation
@@ -18,6 +18,8 @@ | |||
package grpc | |||
|
|||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
common/constant/key.go
Outdated
@@ -25,6 +25,7 @@ const ( | |||
GROUP_KEY = "group" | |||
VERSION_KEY = "version" | |||
INTERFACE_KEY = "interface" | |||
GRPC_MESSAGE_SIZE_KEY = "message_size" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GRPC_MESSAGE_SIZE_KEY change to MESSAGE_SIZE_KEY may be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM |
Ftr: Add grpc max message size config
What this PR does:
增加“在配置文件中设置grpc max message size“”的功能。
Which issue(s) this PR fixes:
Fixes #806
Special notes for your reviewer:
在Service中增加标签为 max_message_size的字段,在开启grpc server时作为参数传入,并写入invoker用于暴露。
客户端拿到服务端url后会更新本地invoker,grpc client会自动调整为与服务端message_size一致。
Does this PR introduce a user-facing change?:
NONE