Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Add grpc max message size config #824

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:
增加“在配置文件中设置grpc max message size“”的功能。
Which issue(s) this PR fixes:

Fixes #806
Special notes for your reviewer:
在Service中增加标签为 max_message_size的字段,在开启grpc server时作为参数传入,并写入invoker用于暴露。
客户端拿到服务端url后会更新本地invoker,grpc client会自动调整为与服务端message_size一致。
Does this PR introduce a user-facing change?:

NONE


@AlexStocks AlexStocks requested review from xujianhai666, cvictory and zouyx and removed request for xujianhai666 and cvictory October 30, 2020 05:59
@@ -18,6 +18,8 @@
package grpc

import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@zouyx zouyx modified the milestones: v1.5.4, v1.5.5 Oct 30, 2020
@zouyx zouyx added the enhancement New feature or request label Nov 3, 2020
@@ -25,6 +25,7 @@ const (
GROUP_KEY = "group"
VERSION_KEY = "version"
INTERFACE_KEY = "interface"
GRPC_MESSAGE_SIZE_KEY = "message_size"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRPC_MESSAGE_SIZE_KEY change to MESSAGE_SIZE_KEY may be better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexStocks AlexStocks merged commit a6a6e15 into apache:develop Nov 7, 2020
@cityiron
Copy link
Contributor

cityiron commented Nov 7, 2020

LGTM

AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants