Fix:generic struct2MapAll #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## develop #822 +/- ##
===========================================
+ Coverage 59.85% 60.14% +0.28%
===========================================
Files 260 260
Lines 12762 12770 +8
===========================================
+ Hits 7639 7680 +41
+ Misses 4164 4133 -31
+ Partials 959 957 -2
Continue to review full report at Codecov.
|
zouyx
approved these changes
Oct 31, 2020
filter/filter_impl/generic_filter.go
Outdated
| if v.Field(i).Kind() == reflect.Struct || v.Field(i).Kind() == reflect.Slice || v.Field(i).Kind() == reflect.Map { | ||
| switch v.Field(i).Kind() { | ||
| case reflect.Struct: | ||
| fallthrough |
AlexStocks
approved these changes
Oct 31, 2020
fangyincheng
force-pushed
the
fix-generic
branch
from
72f08b7
to
7e0df5a
Compare
wongoo
reviewed
Oct 31, 2020
filter/filter_impl/generic_filter.go
Outdated
| if value.CanInterface() { | ||
| if value.Type().String() == "time.Time" { | ||
| setInMap(result, field, value.Interface()) | ||
| break |
wongoo
reviewed
Oct 31, 2020
filter/filter_impl/generic_filter.go
Outdated
| kind := value.Kind() | ||
| if kind == reflect.Struct || kind == reflect.Slice || kind == reflect.Map { | ||
| if value.CanInterface() { | ||
| if value.Type().String() == "time.Time" { |
There was a problem hiding this comment.
use a type check expression would be better: switch v := param.(type), I think there are other structs will be added, especially these in golang sdk.
wongoo
approved these changes
Oct 31, 2020
zouyx
pushed a commit
to zouyx/dubbo-go
that referenced
this pull request
Oct 31, 2020
fix generic struct2MapAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
fix generic struct2MapAll
Which issue(s) this PR fixes:
Fixes #801