Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sentinel windows issue #821

Merged

Conversation

louyuting
Copy link
Contributor

What this PR does:
Upgrade sentinel go to v0.6.2 to degrade system module in windows OS

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
@AlexStocks

Does this PR introduce a user-facing change?:

Upgrade sentinel go to v0.6.2 to degrade system module in windows OS

@AlexStocks AlexStocks requested a review from zouyx October 29, 2020 12:24
@codecov-io
Copy link

Codecov Report

Merging #821 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
- Coverage    59.84%   59.77%   -0.07%     
===========================================
  Files          260      260              
  Lines        12762    12762              
===========================================
- Hits          7637     7629       -8     
- Misses        4169     4177       +8     
  Partials       956      956              
Impacted Files Coverage Δ
registry/kubernetes/registry.go 52.17% <0.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0384e20...a548cc4. Read the comment docs.

@Patrick0308 Patrick0308 merged commit 9eb7c01 into apache:develop Oct 30, 2020
@zouyx zouyx added this to the v1.5.4 milestone Oct 30, 2020
@zouyx zouyx linked an issue Oct 30, 2020 that may be closed by this pull request
zouyx pushed a commit to zouyx/dubbo-go that referenced this pull request Oct 31, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentinel-golang error on windows
5 participants