fix cannot call go provider service when used by java dubbo 2.7.7 version #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
fangyincheng,
hxmhlt,
zouyx and
Patrick0308
and removed request for
fangyincheng
看了一下不一样，这个是优化了一上注册到注册中心的url 注册时去掉值为空的参数。 |
AlexStocks
approved these changes
Oct 29, 2020
其实 773 的真正含义是从 url 里把为空的参数都去掉，所以他复制了 url 过来，然后改了一波，先修复问题吧。 |
zouyx
reviewed
Oct 30, 2020
fangyincheng
approved these changes
Oct 30, 2020
watermelo
approved these changes
Oct 31, 2020
zouyx
pushed a commit
to zouyx/dubbo-go
that referenced
this pull request
Oct 31, 2020
fix cannot call go provider service when used by java dubbo 2.7.7 version # Conflicts: # registry/base_registry.go
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
fix cannot call go provider service when used by java dubbo 2.7.7 version
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
fix cannot call go provider service when used by java dubbo 2.7.7 version # Conflicts: # registry/base_registry.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
remove empty provider registry param key
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: