Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ftr]: dubbo-gen stream support #794

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Oct 16, 2020

What this PR does:
增加了dubbo-gen的stream类型支持

Which issue(s) this PR fixes:
#770

Special notes for your reviewer:
修改了grpc/protoc-gen-dubbo/dubbo/dubbo.go内关于stream类型的pb.go文件生成。
主要修改了grpc.StreamDesc{}结构关于stream类型的服务发现支持。
可直接使用grpc提供的stream服务达到客户端与服务端交互的目的

Does this PR introduce a user-facing change?:
NONE


@codecov-io
Copy link

Codecov Report

Merging #794 into develop will decrease coverage by 0.11%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    59.91%   59.80%   -0.12%     
===========================================
  Files          259      259              
  Lines        12737    12751      +14     
===========================================
- Hits          7632     7626       -6     
- Misses        4152     4172      +20     
  Partials       953      953              
Impacted Files Coverage Δ
registry/consul/registry.go 49.33% <57.14%> (+9.98%) ⬆️
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-10.17%) ⬇️
registry/kubernetes/registry.go 52.17% <0.00%> (-8.70%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 46.51% <0.00%> (-4.66%) ⬇️
filter/filter_impl/hystrix_filter.go 70.19% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0780dcf...8722856. Read the comment docs.

@AlexStocks AlexStocks changed the title Feat/dubbo gen stream support [Ftr]: dubbo-gen stream support Oct 16, 2020
@zouyx zouyx added this to the v1.5.4 milestone Oct 16, 2020
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples

@LaurenceLiZhixin
Copy link
Contributor Author

Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples

Of course, I'll do it right away.

@LaurenceLiZhixin
Copy link
Contributor Author

Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples

I create a sample pr at : apache/dubbo-go-samples#3

@AlexStocks
Copy link
Contributor

hi @xujianhai666 , pls review this pr. thx.

Copy link
Contributor

@Patrick0308 Patrick0308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But I want to pointed out that if we use grpc stream, we will can't control flow by current limiter and the filters will be ignored.

@zouyx zouyx merged commit 45a3656 into apache:develop Oct 22, 2020
@zouyx zouyx linked an issue Oct 22, 2020 that may be closed by this pull request
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc-gen-dubbo compile failed
5 participants