-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ftr]: dubbo-gen stream support #794
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #794 +/- ##
===========================================
- Coverage 59.91% 59.80% -0.12%
===========================================
Files 259 259
Lines 12737 12751 +14
===========================================
- Hits 7632 7626 -6
- Misses 4152 4172 +20
Partials 953 953
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples
Of course, I'll do it right away. |
I create a sample pr at : apache/dubbo-go-samples#3 |
hi @xujianhai666 , pls review this pr. thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, But I want to pointed out that if we use grpc stream, we will can't control flow by current limiter and the filters will be ignored.
[Ftr]: dubbo-gen stream support
What this PR does:
增加了dubbo-gen的stream类型支持
Which issue(s) this PR fixes:
#770
Special notes for your reviewer:
修改了grpc/protoc-gen-dubbo/dubbo/dubbo.go内关于stream类型的pb.go文件生成。
主要修改了grpc.StreamDesc{}结构关于stream类型的服务发现支持。
可直接使用grpc提供的stream服务达到客户端与服务端交互的目的
Does this PR introduce a user-facing change?:
NONE