Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nacos registry can not get namespaceId #778

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Fix: nacos registry can not get namespaceId #778

merged 1 commit into from
Sep 28, 2020

Conversation

at-zhao
Copy link

@at-zhao at-zhao commented Sep 27, 2020

What this PR does:
fix nacos registry can not get namespaceId from RegistryConfig params

Special notes for your reviewer:
I use code configurations instead of configuration files in my projects

Does this PR introduce a user-facing change?:
NONE


@AlexStocks
Copy link
Contributor

@PeaMan pls merge ur pr into the develop branch.

@lzp0412
Copy link
Contributor

lzp0412 commented Sep 28, 2020

LGTM

@watermelo watermelo changed the base branch from master to develop September 28, 2020 09:33
@zouyx zouyx merged commit d2edc54 into apache:develop Sep 28, 2020
@zouyx zouyx added this to the v1.5.3 milestone Oct 15, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Fix: nacos registry can not get namespaceId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants