Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app panic #738

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app panic #738

merged 3 commits into from
Sep 11, 2020

Conversation

zhangshen023
Copy link

What this PR does:
etcdv3 registry lease

@zouyx zouyx linked an issue Sep 8, 2020 that may be closed by this pull request
registry service without lease with etcd #688
Closed
@AlexStocks AlexStocks changed the title etcdv3 lease Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app panic Sep 9, 2020
@zouyx zouyx added the improve Refactor or improve label Sep 10, 2020
@zouyx zouyx added this to the 1.5.2 milestone Sep 10, 2020
beiwei30
beiwei30 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zouyx zouyx merged commit cc3f38d into apache:develop Sep 11, 2020
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Sep 22, 2020
@zouyx
Merge pull request apache#738 from zhangshen023/etcd-lease
4487b56 
Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app  panic
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
@zouyx
Merge pull request #738 from zhangshen023/etcd-lease
7672009 
Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app  panic
kzhan pushed a commit to kzhan/dubbo-go that referenced this pull request Jun 5, 2021
@zouyx
Merge pull request apache#738 from zhangshen023/etcd-lease
a1e3824 
Fix: add etcdv3 lease to defeat provider register info left in the registry when provider app  panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beiwei30 beiwei30 beiwei30 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@zouyx zouyx zouyx approved these changes

@hxmhlt hxmhlt Awaiting requested review from hxmhlt

Assignees

@AlexStocks AlexStocks

Labels
improve Refactor or improve
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

registry service without lease with etcd
4 participants
@zhangshen023 @zouyx @AlexStocks @beiwei30