Fix: can not inovke nacos destroy when graceful shutdown #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
changed the title
zouyx
approved these changes
Aug 4, 2020
AlexStocks
reviewed
Aug 5, 2020
registry/nacos/registry.go
Outdated
| err := nr.DeRegister(url) | ||
| logger.Infof("DeRegister Nacos url:%+v", url) | ||
| if err != nil { | ||
| logger.Errorf("Deregister url:%+v err:%v", url, err.Error()) |
registry/nacos/registry.go
Outdated
| @@ -193,6 +224,13 @@ func (nr *nacosRegistry) IsAvailable() bool { | |||
|
|
|||
| // nolint | |||
| func (nr *nacosRegistry) Destroy() { | |||
| for _, url := range nr.registryUrls { | |||
| err := nr.DeRegister(url) | |||
| logger.Infof("DeRegister Nacos url:%+v", url) | |||
hxmhlt
reviewed
Aug 5, 2020
| } | ||
|
|
||
| func createDeregisterParam(url common.URL, serviceName string) vo.DeregisterInstanceParam { | ||
| if len(url.Ip) == 0 { |
There was a problem hiding this comment.
Pls add func comment
I think only public function need comment
AlexStocks
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、fix not inovke nacos destroy when graceful shutdown
2、upgrade nacos client version