Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rft: Optimize remotes configuration #687

Merged
merged 11 commits into from
Aug 7, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Aug 2, 2020

What this PR does:

  • optimize remotes configuration
  • refactor config center implement.
  • will compatible with baseConfig.ConfigCenterConfig.Address and baseConfig.ConfigCenterConfig.RemoteRef before 1.6.0. After 1.6.0 will not compatible, only baseConfig.ConfigCenterConfig.RemoteRef.

Which issue(s) this PR fixes:

Fixes #501

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added this to the 1.5.1 milestone Aug 2, 2020
@zouyx zouyx linked an issue Aug 2, 2020 that may be closed by this pull request
@zouyx zouyx marked this pull request as draft August 2, 2020 14:46
@zouyx zouyx marked this pull request as ready for review August 3, 2020 15:03
config/base_config.go Outdated Show resolved Hide resolved
config/remote_config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/config_center_config.go Outdated Show resolved Hide resolved
config/config_center_config.go Outdated Show resolved Hide resolved
config/config_center_config_test.go Outdated Show resolved Hide resolved
@zouyx zouyx merged commit 0a98a20 into apache:develop Aug 7, 2020
@zouyx zouyx deleted the feature/optimizeRemotesConfiguration branch September 7, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance: Optimize remotes configuration and constructor
5 participants