Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: update the comments in registy directory #589

Merged
merged 6 commits into from
Jun 19, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Jun 6, 2020

What this PR does:

  • update the comments in registy directory

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx linked an issue Jun 6, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #589 into develop will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #589      +/-   ##
===========================================
- Coverage    67.39%   67.28%   -0.12%     
===========================================
  Files          190      188       -2     
  Lines         9915     9854      -61     
===========================================
- Hits          6682     6630      -52     
+ Misses        2579     2573       -6     
+ Partials       654      651       -3     
Impacted Files Coverage Δ
config_center/configuration_listener.go 0.00% <ø> (ø)
registry/consul/listener.go 81.25% <ø> (ø)
registry/consul/registry.go 43.83% <0.00%> (ø)
registry/directory/directory.go 80.11% <ø> (ø)
registry/etcdv3/listener.go 72.34% <ø> (ø)
registry/etcdv3/registry.go 73.13% <ø> (ø)
registry/kubernetes/listener.go 72.34% <ø> (ø)
registry/kubernetes/registry.go 67.30% <ø> (ø)
registry/nacos/listener.go 80.00% <ø> (ø)
registry/nacos/registry.go 58.42% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41879da...cc499c2. Read the comment docs.

registry/registry.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
config_center/configuration_listener.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/nacos/listener.go Outdated Show resolved Hide resolved
config_center/configuration_listener.go Outdated Show resolved Hide resolved
registry/base_configuration_listener.go Outdated Show resolved Hide resolved
registry/base_configuration_listener.go Outdated Show resolved Hide resolved
registry/base_configuration_listener.go Outdated Show resolved Hide resolved
registry/base_configuration_listener.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
@zouyx zouyx requested a review from AlexStocks June 19, 2020 05:22
@AlexStocks AlexStocks merged commit 3d49970 into apache:develop Jun 19, 2020
@zouyx zouyx deleted the feature/addRegistryComment branch June 24, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for registry directory
5 participants