Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the position of the lock #286

Merged
merged 3 commits into from
Dec 22, 2019

Conversation

pantianying
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #
image

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #286 into develop will increase coverage by 0.3%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #286     +/-   ##
==========================================
+ Coverage    65.52%   65.82%   +0.3%     
==========================================
  Files          111      112      +1     
  Lines         7063     7175    +112     
==========================================
+ Hits          4628     4723     +95     
- Misses        1978     1990     +12     
- Partials       457      462      +5
Impacted Files Coverage Δ
registry/protocol/protocol.go 81.73% <0%> (-1.83%) ⬇️
protocol/dubbo/pool.go 59.51% <100%> (+1.64%) ⬆️
config/service.go 92.3% <0%> (-7.7%) ⬇️
common/proxy/proxy.go 97.75% <0%> (-2.25%) ⬇️
registry/etcdv3/registry.go 50.5% <0%> (-1.02%) ⬇️
protocol/dubbo/codec.go 76.47% <0%> (ø) ⬆️
common/rpc_service.go 88.54% <0%> (ø) ⬆️
config/method_config.go 50% <0%> (ø) ⬆️
cluster/loadbalance/consistent_hash.go 91.17% <0%> (ø)
common/url.go 69.28% <0%> (+0.3%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65659f...e6e0e14. Read the comment docs.

fix travis-ci problem

change lock position

change lock position
protocol/dubbo/pool.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Show resolved Hide resolved
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyx
Copy link
Member

zouyx commented Dec 21, 2019

LGTM

@hxmhlt hxmhlt merged commit 8d46ac0 into apache:develop Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants