fix: unable to merge configurations from the config_center #2616
Conversation
|
FinalT
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 47.73% 47.19% -0.55%
==========================================
Files 341 341
Lines 24994 25286 +292
==========================================
+ Hits 11931 11933 +2
- Misses 11908 12198 +290
Partials 1155 1155 ☔ View full report in Codecov by Sentry. |
| @@ -90,6 +90,7 @@ func (rc *InstanceOptions) init(opts ...InstanceOption) error { | |||
| log.Infof("[Config Center] Config center doesn't start") | |||
| log.Debugf("config center doesn't start because %s", err) | |||
| } else { | |||
| compatInstanceOptions(rcCompat, rc) | |||
There was a problem hiding this comment.
Is this the reverse operation of compatRootConfig(c *InstanceOptions) *config.RootConfig? This is to copy configurations in RootConfig into InstanceOptions while compatRootConfig(c *InstanceOptions) *config.RootConfig does the opposite.
refer:#2614