feat: deep copy the configuration when instanceOptions flow to ServerOptions/ClientOptions #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Options/ClientOptions Fixes: apache#2592 Signed-off-by: setcy <asetcy@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
+ Coverage 47.55% 47.62% +0.06%
==========================================
Files 318 339 +21
Lines 23627 24925 +1298
==========================================
+ Hits 11236 11870 +634
- Misses 11328 11902 +574
- Partials 1063 1153 +90 ☔ View full report in Codecov by Sentry. |
Signed-off-by: setcy <asetcy@gmail.com>
Signed-off-by: setcy <asetcy@gmail.com>
setcy
commented
Feb 18, 2024
Signed-off-by: setcy <asetcy@gmail.com>
Signed-off-by: setcy <asetcy@gmail.com>
DMwangnima
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Nice Job @setcy !
There are some points that we could discuss:
Clonerelys on handwriting individual fields. It is easy to miss corresponding clone procedure when we add fields. I think we should add test to ensure that the missing would not happen.- The issue had illustrated the modifying problem. Maybe we could add a test in dubbo_test.go to cover this scenario?(i.e. Modify some parts of configuration in Client/Server layer, and the configurations in upper layer did not be modified)
Signed-off-by: setcy <asetcy@gmail.com>
|
FoghostCn
pushed a commit
to FoghostCn/dubbo-go
that referenced
this pull request
Mar 27, 2024
…Options/ClientOptions (apache#2596) fixes apache#2592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2592