[3.1] fix: metadata port reuse #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-3.1 #2548 +/- ##
===============================================
- Coverage 44.91% 44.85% -0.06%
===============================================
Files 270 270
Lines 18354 18366 +12
===============================================
- Hits 8243 8238 -5
- Misses 9225 9242 +17
Partials 886 886 ☔ View full report in Codecov by Sentry. |
chickenlj
approved these changes
Dec 27, 2023
| if ok { | ||
| port = protocolConfig.Port | ||
| } else { | ||
| logger.Warnf("[Metadata Service] Dubbo-go %s version's MetadataService does not support triple protocol,"+ |
There was a problem hiding this comment.
The warning message would better be "[Metadata Service] Dubbo-go %s version's MetadataService only support dubbo protocol, ". Because it might be other protocols beyond dubbo and triple.
|
|
@FoghostCn PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2537