Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service discovery subscription #2480

Merged
merged 13 commits into from
Nov 5, 2023

Conversation

chickenlj
Copy link
Contributor

  1. Separate registry subscription from service discovery subscription by extending Directory
  2. Wait for instance notification on service discovery subscription.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #2480 (9dcd037) into main (e8b4ab5) will decrease coverage by 0.03%.
The diff coverage is 29.26%.

❗ Current head 9dcd037 differs from pull request most recent head cbad419. Consider uploading reports for the commit cbad419 to get more accurate results

@@            Coverage Diff             @@
##             main    #2480      +/-   ##
==========================================
- Coverage   44.80%   44.78%   -0.03%     
==========================================
  Files         270      270              
  Lines       18338    18354      +16     
==========================================
+ Hits         8217     8220       +3     
- Misses       9238     9250      +12     
- Partials      883      884       +1     
Files Coverage Δ
common/match.go 0.00% <ø> (ø)
config/otel_config.go 46.51% <ø> (ø)
config/router_config.go 77.19% <ø> (ø)
config_center/configurator/override.go 59.74% <ø> (ø)
registry/protocol/protocol.go 72.10% <100.00%> (+1.41%) ⬆️
registry/base_configuration_listener.go 0.00% <0.00%> (ø)
...ediscovery/service_mapping_change_listener_impl.go 0.00% <0.00%> (ø)
cluster/directory/static/directory.go 60.46% <60.00%> (-6.21%) ⬇️
config_center/mock_dynamic_config.go 0.00% <0.00%> (ø)
cluster/directory/base/directory.go 45.71% <40.00%> (ø)
... and 2 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chickenlj chickenlj merged commit 53843b7 into apache:main Nov 5, 2023
6 checks passed
@chickenlj chickenlj deleted the fix-service-discovery-subscription branch November 5, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants