-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service discovery subscription #2480
Fix service discovery subscription #2480
Conversation
chickenlj
commented
Nov 2, 2023
- Separate registry subscription from service discovery subscription by extending Directory
- Wait for instance notification on service discovery subscription.
Codecov Report
@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
- Coverage 44.80% 44.78% -0.03%
==========================================
Files 270 270
Lines 18338 18354 +16
==========================================
+ Hits 8217 8220 +3
- Misses 9238 9250 +12
- Partials 883 884 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 11f3eff.
Kudos, SonarCloud Quality Gate passed! |