Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rpc exception metrics #2459

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

ev1lQuark
Copy link
Contributor

Main changes

  • implement new metrics:
    • dubbo_provider_requests_failed_total
    • dubbo_consumer_requests_failed_total
    • dubbo_provider_requests_failed_total_aggregate
    • dubbo_consumer_requests_failed_total_aggregate
  • fix a metrics naming error

Next to do

According to the type of RPC exception, implement more detailed metrics to refine the granularity.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2459 (2ae62af) into main (40dd198) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2ae62af differs from pull request most recent head 6dd25d8. Consider uploading reports for the commit 6dd25d8 to get more accurate results

@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   45.11%   45.10%   -0.02%     
==========================================
  Files         269      269              
  Lines       18190    18190              
==========================================
- Hits         8206     8204       -2     
- Misses       9109     9110       +1     
- Partials      875      876       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj merged commit cccb67d into apache:main Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants