Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk registry support customize 'rootPath' #2437

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

xiaomiusa87
Copy link
Contributor

[#2428] zk registry support customize 'rootPath'

@DMwangnima
Copy link
Contributor

This improvement needs to be supported by the configuration API or customized filter so that we need to consider the implications.

@codecov-commenter
Copy link

Codecov Report

Merging #2437 (5f97fec) into main (5ac057d) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 5f97fec differs from pull request most recent head e215e92. Consider uploading reports for the commit e215e92 to get more accurate results

@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
- Coverage   45.18%   45.03%   -0.16%     
==========================================
  Files         269      269              
  Lines       18220    18168      -52     
==========================================
- Hits         8233     8182      -51     
- Misses       9110     9116       +6     
+ Partials      877      870       -7     
Files Coverage Δ
config/registry_config.go 81.81% <ø> (ø)
registry/zookeeper/service_discovery.go 17.36% <100.00%> (+0.49%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 8b04140 into apache:main Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants