Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add some metrics #2362

Merged
merged 4 commits into from
Jul 21, 2023
Merged

feat: add some metrics #2362

merged 4 commits into from
Jul 21, 2023

Conversation

ev1lQuark
Copy link
Contributor

@ev1lQuark ev1lQuark commented Jul 19, 2023 •
edited
Loading

  • dubbo_xxx_qps_total
  • dubbo_xxx_rt_min_milliseconds_aggregate
  • dubbo_xxx_rt_max_milliseconds_aggregate
  • dubbo_xxx_rt_avg_milliseconds_aggregate
  • dubbo_xxx_requests_total_aggregate
  • dubbo_xxx_requests_succeed_aggregate

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #2362 (f59f68b) into main (10336a5) will decrease coverage by 0.11%.
The diff coverage is 67.90%.

❗ Current head f59f68b differs from pull request most recent head 13331a4. Consider uploading reports for the commit 13331a4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
- Coverage   44.68%   44.57%   -0.11%     
==========================================
  Files         299      299              
  Lines       18188    18269      +81     
==========================================
+ Hits         8127     8144      +17     
- Misses       9206     9272      +66     
+ Partials      855      853       -2
Impacted Files Coverage Δ
metrics/prometheus/model.go 25.76% <50.00%> (-13.47%) ⬇️
metrics/prometheus/reporter.go 73.33% <84.61%> (-2.76%) ⬇️
metrics/prometheus/metric_set.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ev1lQuark ev1lQuark changed the title feat: add QPS metrics feat: add some metrics Jul 19, 2023
chickenlj
chickenlj approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ev1lQuark ev1lQuark requested a review from FoghostCn July 21, 2023 02:45
@chickenlj chickenlj merged commit cd76e0f into apache:main Jul 21, 2023
6 checks passed
@ev1lQuark ev1lQuark deleted the qps branch July 21, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyunxing92 zhaoyunxing92 zhaoyunxing92 approved these changes

@chickenlj chickenlj chickenlj approved these changes

@binbin0325 binbin0325 binbin0325 approved these changes

@FoghostCn FoghostCn Awaiting requested review from FoghostCn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ev1lQuark @codecov-commenter @FoghostCn @zhaoyunxing92 @chickenlj @binbin0325