Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unnecessary use of fmt.Sprintf #2352

Merged
merged 1 commit into from
Jul 9, 2023
Merged

chore: unnecessary use of fmt.Sprintf #2352

merged 1 commit into from
Jul 9, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 9, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2352 (be269e8) into main (f6fdbfd) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

❗ Current head be269e8 differs from pull request most recent head 82c3bcb. Consider uploading reports for the commit 82c3bcb to get more accurate results

@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   44.27%   43.93%   -0.35%     
==========================================
  Files         294      294              
  Lines       18019    18019              
==========================================
- Hits         7978     7916      -62     
- Misses       9194     9259      +65     
+ Partials      847      844       -3     
Impacted Files Coverage Δ
config/reference_config.go 24.04% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@justxuewei justxuewei merged commit f831ea5 into apache:main Jul 9, 2023
6 checks passed
@testwill testwill deleted the fmt branch July 9, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants