Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print logs of registered providers and consumers #2320

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

ev1lQuark
Copy link
Contributor

Fix: #2319

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Merging #2320 (c463760) into main (4b13d2b) will increase coverage by 0.15%.
The diff coverage is 61.11%.

❗ Current head c463760 differs from pull request most recent head a3b32b2. Consider uploading reports for the commit a3b32b2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
+ Coverage   44.05%   44.21%   +0.15%     
==========================================
  Files         285      294       +9     
  Lines       17669    17863     +194     
==========================================
+ Hits         7784     7898     +114     
- Misses       9057     9123      +66     
- Partials      828      842      +14     
Impacted Files Coverage Δ
metadata/service/local/service_proxy.go 63.09% <ø> (+0.74%) ⬆️
protocol/dubbo3/dubbo3_invoker.go 58.33% <ø> (ø)
protocol/dubbo3/dubbo3_protocol.go 56.02% <ø> (ø)
protocol/grpc/client.go 60.25% <ø> (ø)
protocol/grpc/server.go 63.44% <ø> (ø)
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
config/consumer_config.go 23.52% <40.00%> (+1.48%) ⬆️
config/provider_config.go 46.71% <62.50%> (+5.17%) ⬆️
config/service.go 85.36% <100.00%> (+2.50%) ⬆️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please keep the previous import format unchanged.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please keep the previous import format unchanged.

@ev1lQuark ev1lQuark requested a review from AlexStocks June 2, 2023 12:36
Copy link

@bodhili bodhili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove else

config/provider_config.go Show resolved Hide resolved
config/provider_config.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chickenlj chickenlj merged commit b998087 into apache:main Jun 3, 2023
@ev1lQuark ev1lQuark deleted the log branch June 3, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print logs of registered providers and consumers
5 participants