Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:polaris service discovery cause nil panic #2317

Merged
merged 1 commit into from
May 31, 2023

Conversation

chuntaojun
Copy link
Contributor

@chuntaojun chuntaojun commented May 21, 2023

try to resolve PR:#2314 polaris panic error

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2317 (fd9aa7b) into main (4b13d2b) will increase coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
+ Coverage   44.05%   44.19%   +0.14%     
==========================================
  Files         285      294       +9     
  Lines       17669    17845     +176     
==========================================
+ Hits         7784     7887     +103     
- Misses       9057     9118      +61     
- Partials      828      840      +12     
Impacted Files Coverage Δ
config/provider_config.go 42.51% <0.00%> (+0.98%) ⬆️
metadata/service/local/service_proxy.go 63.09% <ø> (+0.74%) ⬆️
protocol/dubbo3/dubbo3_invoker.go 58.33% <ø> (ø)
protocol/dubbo3/dubbo3_protocol.go 56.02% <ø> (ø)
protocol/grpc/client.go 60.25% <ø> (ø)
protocol/grpc/server.go 63.44% <ø> (ø)
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
config/service.go 85.36% <100.00%> (+2.50%) ⬆️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei justxuewei merged commit cbcfdb4 into apache:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants