Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore zk node already exist when store provider/consumer metadata #2311

Merged
merged 5 commits into from
Jun 3, 2023

Conversation

Leospard
Copy link
Contributor

@Leospard Leospard commented May 4, 2023

There is a gocron do a metadata report once a day, we need to ignore 'node already exist' error to avoid printing log error.
This case only occurs in zookeeper.

@AlexStocks
Copy link
Contributor

这个 pr 有关联的 issue 描述吗?

@Leospard
Copy link
Contributor Author

Leospard commented May 4, 2023

这个 pr 有关联的 issue 描述吗?

暂时没有相关 issue ,这是之前测出的小 bug。主要触发原因就是一旦开启 metadata report 将元数据上报至元数据中心的功能,会有定时器定期全量上报元数据(不管有没有更新),这在 zk 客户端就会产生节点已存在的 err,我这里的修复也是参考 metadata/report/zookeeper/report.go:75 PublishMetadata 的处理去做的忽略。

@AlexStocks
Copy link
Contributor

这个 pr 有关联的 issue 描述吗?

暂时没有相关 issue ,这是之前测出的小 bug。主要触发原因就是一旦开启 metadata report 将元数据上报至元数据中心的功能,会有定时器定期全量上报元数据(不管有没有更新),这在 zk 客户端就会产生节点已存在的 err,我这里的修复也是参考 metadata/report/zookeeper/report.go:75 PublishMetadata 的处理去做的忽略。

好的。辛苦继续把 ci 失败修复下

@Leospard
Copy link
Contributor Author

Leospard commented May 5, 2023

这个 pr 有关联的 issue 描述吗?

暂时没有相关 issue ,这是之前测出的小 bug。主要触发原因就是一旦开启 metadata report 将元数据上报至元数据中心的功能,会有定时器定期全量上报元数据(不管有没有更新),这在 zk 客户端就会产生节点已存在的 err,我这里的修复也是参考 metadata/report/zookeeper/report.go:75 PublishMetadata 的处理去做的忽略。

好的。辛苦继续把 ci 失败修复下

看了下好像是 polaris 的问题...不是这个 pr 带来的问题,可能需要请教一下其他同学

@AlexStocks
Copy link
Contributor

这个 pr 有关联的 issue 描述吗?

暂时没有相关 issue ,这是之前测出的小 bug。主要触发原因就是一旦开启 metadata report 将元数据上报至元数据中心的功能,会有定时器定期全量上报元数据(不管有没有更新),这在 zk 客户端就会产生节点已存在的 err,我这里的修复也是参考 metadata/report/zookeeper/report.go:75 PublishMetadata 的处理去做的忽略。

好的。辛苦继续把 ci 失败修复下

看了下好像是 polaris 的问题...不是这个 pr 带来的问题,可能需要请教一下其他同学

问下学蔚和春少

@Leospard
Copy link
Contributor Author

Leospard commented May 5, 2023

这个 pr 有关联的 issue 描述吗?

暂时没有相关 issue ,这是之前测出的小 bug。主要触发原因就是一旦开启 metadata report 将元数据上报至元数据中心的功能,会有定时器定期全量上报元数据(不管有没有更新),这在 zk 客户端就会产生节点已存在的 err,我这里的修复也是参考 metadata/report/zookeeper/report.go:75 PublishMetadata 的处理去做的忽略。

好的。辛苦继续把 ci 失败修复下

看了下好像是 polaris 的问题...不是这个 pr 带来的问题,可能需要请教一下其他同学

问下学蔚和春少

👌

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #2311 (7fbbb93) into main (cbcfdb4) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2311      +/-   ##
==========================================
- Coverage   44.33%   44.18%   -0.16%     
==========================================
  Files         294      294              
  Lines       17951    17844     -107     
==========================================
- Hits         7959     7884      -75     
+ Misses       9144     9119      -25     
+ Partials      848      841       -7     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

metadata/report/zookeeper/report.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chickenlj chickenlj merged commit 12f5211 into apache:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants