Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:timeout don't support ms bug #2086 #2105

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

Code-Fight
Copy link
Contributor

@Code-Fight Code-Fight commented Nov 4, 2022

What this PR does:
fix timeout don't support ms bug
Which issue(s) this PR fixes:
Fixes #
#2086
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@AlexStocks AlexStocks merged commit ef53b9b into apache:3.0 Nov 5, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants