-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable publish servicedefinition to metadata center #2025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #2025 +/- ##
==========================================
- Coverage 44.84% 44.60% -0.25%
==========================================
Files 283 283
Lines 17150 17111 -39
==========================================
- Hits 7691 7632 -59
- Misses 8648 8672 +24
+ Partials 811 807 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chickenlj
requested changes
Aug 24, 2022
cjphaha
approved these changes
Aug 26, 2022
binbin0325
approved these changes
Sep 15, 2022
@Leospard 如果这个工作做完,准备好让大家review,请把 title 中的 WIP 去掉 |
baerwang
reviewed
Sep 16, 2022
@@ -43,6 +47,10 @@ type BaseMetadataIdentifier struct { | |||
func joinParams(joinChar string, params []string) string { | |||
var joinedStr string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string change strings.Builder?
Leospard
force-pushed
the
metatype_dev
branch
from
September 18, 2022 10:08
34132f3
to
46b3051
Compare
Leospard
force-pushed
the
metatype_dev
branch
from
September 18, 2022 14:10
68c889e
to
4d8844e
Compare
Leospard
changed the title
[WIP] Enable publish servicedefinition to metadata center
Enable publish servicedefinition to metadata center
Sep 20, 2022
AlexStocks
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
fix zk invalid path when metadata-type: remote
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed