Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: add dubbo-go cli and edit readme #1971

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Jul 15, 2022

Move dubbogo-cli to the dubbogo-cli directory and modify the readme document.
Refer #1799

@cjphaha cjphaha changed the base branch from master to 3.0 July 15, 2022 10:51
@AlexStocks
Copy link
Contributor

pls fix the ci failure

@cjphaha cjphaha closed this Aug 26, 2022
@cjphaha cjphaha reopened this Aug 26, 2022
@cjphaha cjphaha force-pushed the feature/add_dubbogo_cli_3.0 branch from 5510a17 to 1db16dd Compare August 27, 2022 11:54
@codecov-commenter
Copy link

Codecov Report

Merging #1971 (df3c99f) into 3.0 (9d88f31) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #1971      +/-   ##
==========================================
+ Coverage   44.54%   44.69%   +0.14%     
==========================================
  Files         283      283              
  Lines       17069    17106      +37     
==========================================
+ Hits         7603     7645      +42     
+ Misses       8663     8653      -10     
- Partials      803      808       +5     
Impacted Files Coverage Δ
config/consumer_config.go 22.58% <0.00%> (ø)
config/provider_config.go 41.53% <0.00%> (ø)
protocol/dubbo3/dubbo3_protocol.go 54.54% <0.00%> (ø)
config/graceful_shutdown_config.go 89.83% <0.00%> (-2.90%) ⬇️
config/logger_config.go 63.33% <0.00%> (+0.62%) ⬆️
metadata/definition/definition.go 70.66% <0.00%> (+7.87%) ⬆️
metadata/report/delegate/delegate_report.go 35.09% <0.00%> (+8.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjphaha cjphaha changed the title [WIP]: add dubbo-go cli and edit readme Ftr: add dubbo-go cli and edit readme Aug 27, 2022
var include string
var thread int
var onlyError bool
var err error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放在一个 var () 代码块里面就可以了

@AlexStocks AlexStocks merged commit 1069dea into apache:3.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants