Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix revision calc #1926

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix: fix revision calc #1926

merged 1 commit into from
Jun 21, 2022

Conversation

ray2011
Copy link
Contributor

@ray2011 ray2011 commented Jun 7, 2022

What this PR does:
fix different revision calc in service_revision_customizer.go:resolveRevision and metadata_info.go:(*MetadataInfo).CalcAndGetRevision, which make client get empty server metadata.

Which issue(s) this PR fixes:
Fixes #1925

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #1926 (ce18570) into 3.0 (07defad) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #1926      +/-   ##
==========================================
- Coverage   45.02%   44.93%   -0.09%     
==========================================
  Files         287      287              
  Lines       17135    17135              
==========================================
- Hits         7715     7700      -15     
- Misses       8606     8622      +16     
+ Partials      814      813       -1     
Impacted Files Coverage Δ
common/metadata_info.go 0.00% <0.00%> (ø)
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-7.95%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
cluster/loadbalance/ringhash/ring.go 87.32% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07defad...ce18570. Read the comment docs.

common/metadata_info.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit e10e208 into apache:3.0 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants