Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: split protocol/dubbo/pool.go gettyRPCClient.close and gettyRPCClientPool.remove #186

Merged
merged 4 commits into from
Sep 2, 2019

Conversation

AlexStocks
Copy link
Contributor

What this PR does:
Imp: split protocol/dubbo/pool.go gettyRPCClient.close and gettyRPCClientPool.remove

@codecov-io
Copy link

codecov-io commented Sep 1, 2019

Codecov Report

Merging #186 into develop will decrease coverage by 1.06%.
The diff coverage is 20.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #186      +/-   ##
==========================================
- Coverage    67.86%   66.8%   -1.07%     
==========================================
  Files           94      94              
  Lines         5850    5862      +12     
==========================================
- Hits          3970    3916      -54     
- Misses        1468    1535      +67     
+ Partials       412     411       -1
Impacted Files Coverage Δ
protocol/dubbo/pool.go 57.43% <20.68%> (-17.43%) ⬇️
protocol/dubbo/listener.go 54.16% <0%> (-10.65%) ⬇️
protocol/dubbo/codec.go 73.52% <0%> (-8.83%) ⬇️
protocol/dubbo/readwriter.go 71.79% <0%> (-2.57%) ⬇️
protocol/jsonrpc/server.go 51.9% <0%> (-1.15%) ⬇️
registry/etcdv3/registry.go 56.89% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8cb98e...aa5c160. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hxmhlt hxmhlt merged commit 141f1db into apache:develop Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants