Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adasvc): fix issue where limitation not updates #1784

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Mar 14, 2022

What this PR does:

  • concurrency is renamed to maxCapacity
  • fix the way calculating the value of maxCapacity
  • limitation is not updated as expectation

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@justxuewei justxuewei changed the title fix(adasvc): fix issue where limitation not updates [WIP] fix(adasvc): fix issue where limitation not updates Mar 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1784 (b7134f9) into 3.0 (e1c2a8f) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b7134f9 differs from pull request most recent head febe6fb. Consider uploading reports for the commit febe6fb to get more accurate results

@@            Coverage Diff             @@
##              3.0    #1784      +/-   ##
==========================================
- Coverage   47.60%   47.57%   -0.04%     
==========================================
  Files         262      262              
  Lines       15114    15114              
==========================================
- Hits         7195     7190       -5     
- Misses       7134     7142       +8     
+ Partials      785      782       -3     
Impacted Files Coverage Δ
cluster/loadbalance/p2c/loadbalance.go 76.36% <ø> (ø)
remoting/etcdv3/listener.go 45.13% <0.00%> (-1.77%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c2a8f...febe6fb. Read the comment docs.

@justxuewei justxuewei changed the title [WIP] fix(adasvc): fix issue where limitation not updates fix(adasvc): fix issue where limitation not updates Mar 22, 2022
@justxuewei justxuewei merged commit c12c1d6 into apache:3.0 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants