Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-go to support triple stream ctx attachement #1736

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Jan 27, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes apache/dubbo-go-samples#315

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1736 (3cb4d1b) into 3.0 (b5e3805) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1736      +/-   ##
==========================================
- Coverage   42.87%   42.68%   -0.19%     
==========================================
  Files         256      256              
  Lines       14782    14782              
==========================================
- Hits         6338     6310      -28     
- Misses       7718     7750      +32     
+ Partials      726      722       -4     
Impacted Files Coverage Δ
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (-13.34%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e3805...3cb4d1b. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin added this to the 3.0.1 milestone Jan 27, 2022
@justxuewei justxuewei merged commit 6402da5 into 3.0 Jan 28, 2022
@justxuewei justxuewei deleted the ftr/triple-stream-ctx branch August 15, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants