Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix adaptive service issues #1718

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Conversation

justxuewei
Copy link
Member

What this PR does:

  • fix issue where the updater not found when reaching the limitation
  • add an util for detecting the error reaching the limitation

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #1718 (a4dabf9) into 3.0 (7168e8e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1718      +/-   ##
==========================================
- Coverage   42.78%   42.76%   -0.03%     
==========================================
  Files         256      256              
  Lines       14776    14776              
==========================================
- Hits         6322     6319       -3     
- Misses       7736     7739       +3     
  Partials      718      718              
Impacted Files Coverage Δ
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7168e8e...a4dabf9. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor

Looking forward to the great behavior of adaptive service.

@AlexStocks AlexStocks merged commit 06da7ce into apache:3.0 Jan 18, 2022
@justxuewei justxuewei deleted the fix/adasvc branch January 27, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants