Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: change log to dubbo go logger #1617

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Nov 25, 2021

Some code in the project uses native log, such as :

import (
    "log"
)

log.Printf("xxx")

Now change it to the unified use of the framework itself logger, the code is in common/logger ,the modified method of use is:

import (
    log "dubbo.apache.org/dubbo-go/v3/common/logger"
)

log.Infof("xxx")

@codecov-commenter
Copy link

Codecov Report

Merging #1617 (db31740) into 3.0 (fe19465) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head db31740 differs from pull request most recent head 70deec6. Consider uploading reports for the commit 70deec6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1617      +/-   ##
==========================================
- Coverage   40.97%   40.91%   -0.07%     
==========================================
  Files         251      251              
  Lines       14405    14405              
==========================================
- Hits         5903     5894       -9     
- Misses       7820     7830      +10     
+ Partials      682      681       -1     
Impacted Files Coverage Δ
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-7.95%) ⬇️
metrics/prometheus/reporter.go 28.57% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe19465...70deec6. Read the comment docs.

@cjphaha cjphaha changed the title feat: change log to dubbo go logger Ftr: change log to dubbo go logger Nov 26, 2021
@cjphaha cjphaha merged commit a6aa373 into apache:3.0 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants