Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add nacos methods key #1608

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

  • nacos registry servicce provider's url methods key is empty now, and is used by pixiu-gateway

@codecov-commenter
Copy link

Codecov Report

Merging #1608 (8e87f98) into 3.0 (7d08891) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1608      +/-   ##
==========================================
- Coverage   41.00%   40.98%   -0.03%     
==========================================
  Files         251      251              
  Lines       14402    14403       +1     
==========================================
- Hits         5906     5903       -3     
- Misses       7813     7818       +5     
+ Partials      683      682       -1     
Impacted Files Coverage Δ
registry/nacos/registry.go 48.55% <100.00%> (+0.37%) ⬆️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️
metadata/report/delegate/delegate_report.go 34.43% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d08891...8e87f98. Read the comment docs.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 03cf5fd into apache:3.0 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants