refactor listenDirEvent #1589
Merged
refactor listenDirEvent #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. remove CLEAR label; 2. remove register/unregister logic for watch children; 3. reorder the zk dynamic configuration code 4. adapt the gost
Codecov Report
@@ Coverage Diff @@
## 3.0 #1589 +/- ##
==========================================
+ Coverage 41.15% 41.29% +0.14%
==========================================
Files 250 250
Lines 14277 14262 -15
==========================================
+ Hits 5875 5890 +15
+ Misses 7719 7689 -30
Partials 683 683
Continue to review full report at Codecov.
|
XiaoWeiKIN
reviewed
Nov 16, 2021
justxuewei
reviewed
Nov 18, 2021
| @@ -150,7 +150,11 @@ func (r *zkRegistry) InitListeners() { | |||
|
|
|||
| // CreatePath creates the path in the registry center of zookeeper | |||
| func (r *zkRegistry) CreatePath(path string) error { | |||
| return r.ZkClient().Create(path) | |||
| err := r.ZkClient().Create(path) | |||
| if err != nil && err != zk.ErrNodeExists { | |||
There was a problem hiding this comment.
IMO, using errors.Is() is better than !=.
There was a problem hiding this comment.
I think != is just ok
justxuewei
reviewed
Nov 18, 2021
| @@ -80,15 +81,20 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu | |||
| logger.Errorf("zookeeper client start error ,error message is %v", err) | |||
| return nil, err | |||
| } | |||
| err = c.client.Create(c.rootPath) | |||
| if err != nil && err != zk.ErrNodeExists { | |||
LaurenceLiZhixin
approved these changes
Nov 18, 2021
AlexStocks
approved these changes
Nov 18, 2021
justxuewei
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: