Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine grpc code #1261

Merged
merged 2 commits into from
Jun 17, 2021
Merged

refine grpc code #1261

merged 2 commits into from
Jun 17, 2021

Conversation

gaoxinge
Copy link

What this PR does:

  • remove grpc plugin (or pb.go) dependency on grpc.DubboGrpcService. Because grpc test depends on pb.go, avoid circular dependency
  • move pb and pb.go to internal package

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #1261 (dfe6eb1) into 3.0 (968650f) will decrease coverage by 3.86%.
The diff coverage is 50.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1261      +/-   ##
==========================================
- Coverage   59.53%   55.66%   -3.87%     
==========================================
  Files         259      273      +14     
  Lines       12737    12826      +89     
==========================================
- Hits         7583     7140     -443     
- Misses       4199     4784     +585     
+ Partials      955      902      -53     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 284 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bcbee...dfe6eb1. Read the comment docs.

@AlexStocks AlexStocks merged commit 72c00a4 into apache:3.0 Jun 17, 2021
@gaoxinge gaoxinge deleted the 3.0 branch June 17, 2021 06:15
@lethexixin
Copy link

lethexixin commented Jul 30, 2021

我想问一下, 按照这个PR的设计, 在我真正使用的时候, 你这里每个pb.go 都定义这个DubboGrpcService , 如果我把多个proto生成的pb.go放到同一个文件夹, 就会造成重复定义的冲突啊, 该如何解决呢?

image

@gaoxinge
Copy link
Author

@lethexixin 有道理,我这周末看一下

@AlexStocks
Copy link
Contributor

Pls do not merge until @gaoxinge says this pr is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants