-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine grpc code #1261
Merged
Merged
refine grpc code #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1261 +/- ##
==========================================
- Coverage 59.53% 55.66% -3.87%
==========================================
Files 259 273 +14
Lines 12737 12826 +89
==========================================
- Hits 7583 7140 -443
- Misses 4199 4784 +585
+ Partials 955 902 -53
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Jun 16, 2021
zouyx
approved these changes
Jun 17, 2021
LaurenceLiZhixin
approved these changes
Jun 17, 2021
@lethexixin 有道理,我这周末看一下 |
Pls do not merge until @gaoxinge says this pr is ready. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
grpc.DubboGrpcService
. Because grpc test depends on pb.go, avoid circular dependencySpecial notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: