Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rft: Restructuring remoting metadata service #1227

Conversation

justxuewei
Copy link
Member

What this PR does:

Restructuring RemotingMetadataService to enhance the readability.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@justxuewei justxuewei force-pushed the xavierniu/restructure-remoting-metadata-serivce branch from 04c0d2d to 80171e9 Compare May 30, 2021 08:42
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #1227 (8a6baae) into 3.0 (968650f) will decrease coverage by 3.68%.
The diff coverage is 50.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1227      +/-   ##
==========================================
- Coverage   59.53%   55.85%   -3.69%     
==========================================
  Files         259      272      +13     
  Lines       12737    12880     +143     
==========================================
- Hits         7583     7194     -389     
- Misses       4199     4792     +593     
+ Partials      955      894      -61     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ee29d...8a6baae. Read the comment docs.

@justxuewei justxuewei changed the title restructure remoting metadata service Rft: restructure remoting metadata service May 30, 2021
@justxuewei justxuewei changed the title Rft: restructure remoting metadata service Rft: Restructuring remoting metadata service May 30, 2021
@AlexStocks AlexStocks merged commit 3d57cfd into apache:3.0 Jun 7, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants