application service discovery support etcd reporter #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxmhlt
reviewed
May 28, 2021
gaoxinge
approved these changes
May 30, 2021
justxuewei
reviewed
May 30, 2021
metadata/report/etcd/report_test.go
Outdated
| err = metadataReport.PublishAppMetadata(subMi, metadataInfo) | ||
| assert.Nil(t, err) | ||
|
|
||
| _, err = metadataReport.GetAppMetadata(subMi) |
There was a problem hiding this comment.
Why don't check the return value of GetAppMetadata here?
There was a problem hiding this comment.
Yes, It should be...
LaurenceLiZhixin
approved these changes
Jun 2, 2021
Codecov Report
@@ Coverage Diff @@
## 3.0 #1221 +/- ##
==========================================
- Coverage 59.53% 55.84% -3.69%
==========================================
Files 259 272 +13
Lines 12737 12896 +159
==========================================
- Hits 7583 7202 -381
- Misses 4199 4792 +593
+ Partials 955 902 -53
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Jun 3, 2021
AlexStocks
reviewed
Jun 3, 2021
| } | ||
|
|
||
| // PublishAppMetadata publish metadata info to etcd | ||
| func (e *etcdMetadataReport) PublishAppMetadata(metadataIdentifier *identifier.SubscriberMetadataIdentifier, info *common.MetadataInfo) error { | ||
| // TODO will implement | ||
| panic("implement me") | ||
| key := e.getNodeKey(metadataIdentifier) |
There was a problem hiding this comment.
key := e.getNodeKey(metadataIdentifier)
value, err := json.Marshal(info)
if err == nil {
err = e.client.Put(key, string(value))
}
return err
AlexStocks
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
1 application service discovery support etcd reporter
2 fix the comments of PublishAppMetadata and GetAppMetadata
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: