Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1214 - go race detect #1220

Merged
merged 6 commits into from
May 27, 2021
Merged

fix: #1214 - go race detect #1220

merged 6 commits into from
May 27, 2021

Conversation

beiwei30
Copy link
Member

What this PR does:

fix #1214

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #1220 (8ff4dd4) into 1.5 (a10ff4d) will decrease coverage by 7.54%.
The diff coverage is 60.35%.

❗ Current head 8ff4dd4 differs from pull request most recent head 39cae59. Consider uploading reports for the commit 39cae59 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1220      +/-   ##
==========================================
- Coverage   66.13%   58.59%   -7.55%     
==========================================
  Files         174      272      +98     
  Lines        9343    13235    +3892     
==========================================
+ Hits         6179     7755    +1576     
- Misses       2541     4523    +1982     
- Partials      623      957     +334     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9a038...39cae59. Read the comment docs.

Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 1a83480 into apache:1.5 May 27, 2021
@beiwei30 beiwei30 deleted the issue1214 branch May 27, 2021 15:06
beiwei30 added a commit to beiwei30/dubbo-go that referenced this pull request May 27, 2021
AlexStocks pushed a commit that referenced this pull request May 28, 2021
* fix: #1214 - go race detect (#1220)

* add contract for Directory interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants