Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftr: add grpc server reflection register logic #1216

Merged
merged 1 commit into from
May 26, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:
add grpc server reflection register logic
Which issue(s) this PR fixes:

Fixes #1215

Special notes for your reviewer:
增加grpc server的reflection.Register逻辑,为grpcurl调试工具提供支持。
开发者需要注意,在使用grpcurl调试的过程中,传递的接口名/方法名需要与编译后的pb.go文件内一致,并非Dubbo-go框架配置中的InterfaceName,对于这个InterfaceName,框架只用于进行服务注册发现,网络请求逻辑还是走的grpc,也就是.pb.go文件内的接口名/方法名

Does this PR introduce a user-facing change?:


Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@codecov-commenter
Copy link

Codecov Report

Merging #1216 (fc78b2f) into 3.0 (968650f) will decrease coverage by 3.54%.
The diff coverage is 50.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1216      +/-   ##
==========================================
- Coverage   59.53%   55.99%   -3.55%     
==========================================
  Files         259      272      +13     
  Lines       12737    12861     +124     
==========================================
- Hits         7583     7201     -382     
- Misses       4199     4761     +562     
+ Partials      955      899      -56     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56fa17f...fc78b2f. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin merged commit c628422 into apache:3.0 May 26, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants